sablink/entropy
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[entropy.client] catch RuntimeError exceptions when calling os.path.realpath (cope with circular symlink)

Browse Source
This commit is contained in:
Fabio Erculiani
2010-02-16 11:07:31 +01:00
parent 06d73fc66e
commit d45bc5277a
1 changed files with 45 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/entropy/client/interfaces/package.py
+45 -2
View File
@@ -1354,8 +1354,51 @@ class Package:
if do_return:
return 0
if os.path.realpath(fromfile) == os.path.realpath(tofile) and \
os.path.islink(tofile):
try:
from_r_path = os.path.realpath(fromfile)
except RuntimeError:
# circular symlink, fuck!
# really weird...!
self.Entropy.clientLog.log(
"[Package]",
etpConst['logging']['normal_loglevel_id'],
"WARNING!!! %s is a circular symlink !!!" % (fromfile,)
)
mytxt = "%s: %s" % (
_("Circular symlink issue"),
const_convert_to_unicode(fromfile),
)
self.Entropy.output(
darkred("QA: ") + darkred(mytxt),
importance = 1,
type = "warning",
header = red(" !!! ")
)
from_r_path = fromfile
try:
to_r_path = os.path.realpath(tofile)
except RuntimeError:
# circular symlink, fuck!
# really weird...!
self.Entropy.clientLog.log(
"[Package]",
etpConst['logging']['normal_loglevel_id'],
"WARNING!!! %s is a circular symlink !!!" % (tofile,)
)
mytxt = "%s: %s" % (
_("Circular symlink issue"),
const_convert_to_unicode(tofile),
)
self.Entropy.output(
darkred("QA: ") + darkred(mytxt),
importance = 1,
type = "warning",
header = red(" !!! ")
)
to_r_path = tofile
if from_r_path == to_r_path and os.path.islink(tofile):
# there is a serious issue here, better removing tofile,
# happened to someone.