sablink/entropy
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[solo.commands.search] do not hold the inst_repo lock while using stdio functions

Browse Source 
print_package_info is already able to deal with stale data and we
better not deadlock other threads or processes there.
This commit is contained in:
Fabio Erculiani
2013-12-05 07:56:22 +01:00
parent aa30310ae2
commit b0c85ffcce
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
client/solo/commands/search.py
View File

@@ -196,18 +196,20 @@ Search for packages.
entropy_client, string)
inst_repo = entropy_client.installed_repository()
with inst_repo.shared():
for pkg_id, pkg_repo in results:
for pkg_id, pkg_repo in results:
dbconn = entropy_client.open_repository(pkg_repo)
if not dbconn.isPackageIdAvailable(pkg_id):
continue
repo = entropy_client.open_repository(pkg_repo)
if not repo.isPackageIdAvailable(pkg_id):
continue
print_package_info(
pkg_id, entropy_client, dbconn,
extended = self._verbose,
installed_search = dbconn is inst_repo,
quiet = self._quiet)
# this method is fault tolerant and we better not
# hold the installed repository lock during print
# because we can deadlock other processes/threads.
print_package_info(
pkg_id, entropy_client, repo,
extended = self._verbose,
installed_search = repo is inst_repo,
quiet = self._quiet)
return results