[builder, sabayon-buildpackages] add QA_CHECKS env variable

builder

@@ -36,6 +36,7 @@ my $build_injected_args       = $ENV{BUILD_INJECTED_ARGS};
 my $equo_masks                = $ENV{EQUO_MASKS};
 my $equo_unmasks              = $ENV{EQUO_UNMASKS};
 my $remote_overlay            = $ENV{REMOTE_OVERLAY};
+my $repoman_check             = $ENV{QA_CHECKS} // 0;
 
 my $make_conf = $ENV{MAKE_CONF};
 
@@ -52,6 +53,7 @@ help() if $help;
 
 $ENV{LC_ALL}             = "en_US.UTF-8";    #here be dragons
 $ENV{ETP_NONINTERACTIVE} = 1;
+$ENV{ACCEPT_LICENSE} = "*";    # we can use wildcard since entropy 302
 
 # A barely print replacement
 sub say { print join( "\n", @_ ) . "\n"; }
@@ -307,8 +309,6 @@ unless ( $skip_portage_sync == 1 ) {
 
 # preparing for MOAR automation
 qx|eselect profile set $profile|;
-qx{ls /usr/portage/licenses -1 | xargs -0 > /etc/entropy/packages/license.accept}
-  ;    #HAHA
 
 if ( $use_equo && $entropy_repository eq "weekly" ) {
     qx|equo repo disable sabayonlinux.org|;
@@ -321,6 +321,10 @@ elsif ( $use_equo && $entropy_repository eq "testing" ) {
 }
 
 if ($use_equo) {
+
+    say "Devkit version:";
+    system("equo s -vq app-misc/sabayon-devkit");
+
     if ( $enman_repositories and $enman_repositories ne "" ) {
         my @enman_toadd = split( / /, $enman_repositories );
         safe_call("enman add $_") for @enman_toadd;
@@ -339,9 +343,12 @@ if ($use_equo) {
 
 system("cp -rf $make_conf /etc/portage/make.conf") if $make_conf;
 
-qx|echo 'ACCEPT_LICENSE="*"' >> /etc/portage/make.conf|;    #just plain evil
 
-my @packages = @ARGV;
+my @packages          = @ARGV;
+my @injected_packages = ();
+if ($build_injected_args) {
+    @injected_packages = split( / /, $build_injected_args );
+}
 
 if ($use_equo) {
 
@@ -401,14 +408,16 @@ if ($use_equo) {
     }
 }
 
+say "*** Repoman checks ***";
+if ( $repoman_check == 1 ) {
+     say "*** QA checks for $_" && system("pushd \$(dirname \$(equery which $_ 2>/dev/null)); repoman; popd") for ( @packages, @injected_packages );
+}
+
 say "*** Ready to compile, finger crossed ***";
 
 system("emerge --info")
   ; #always give detailed information about the building environment, helpful to debug
 
-say "Devkit version:";
-system("equo s -vq app-misc/sabayon-devkit");
-
 my $rt;
 
 if ( $emerge_remove and $emerge_remove ne "" ) {
@@ -431,10 +440,7 @@ else {
 my $return = $rt >> 8;
 
 # best effort -B
-if ($build_injected_args) {
-    system("emerge $emerge_defaults_args -j $jobs -B $_")
-      for ( split( / /, $build_injected_args ) );
-}
+system("emerge $emerge_defaults_args -j $jobs -B $_") for (@injected_packages);
 
 if ($preserved_rebuild) {
 

sabayon-buildpackages

@@ -52,6 +52,7 @@ docker_volumes=( -v "$OUTPUT_DIR:/usr/portage/packages" )
 [ -z "$REMOTE_OVERLAY" ] || docker_env+=(-e "REMOTE_OVERLAY=$REMOTE_OVERLAY")
 [ -z "$REMOVE_LAYMAN_OVERLAY" ] || docker_env+=(-e "REMOVE_LAYMAN_OVERLAY=$REMOVE_LAYMAN_OVERLAY")
 [ -z "$REMOVE_REMOTE_OVERLAY" ] || docker_env+=(-e "REMOVE_REMOTE_OVERLAY=$REMOVE_REMOTE_OVERLAY")
+[ -z "$QA_CHECKS" ] || docker_env+=(-e "QA_CHECKS=$QA_CHECKS")
 
 [ -d "$LOCAL_OVERLAY" ] && docker_volumes+=(-v "$LOCAL_OVERLAY:/usr/local/local_portage")
 

sabayondevkit-functions.sh

@@ -11,9 +11,10 @@ die() { echo "$@" 1>&2 ; exit 1; }
 
 build() {
 local SEARCH=$1
-local EMERGE_DEFAULT_ARGS=${2:---accept-properties=-interactive --verbose --oneshot --nospinner --quiet-build=y --quiet-fail --fail-clean=y --complete-graph --buildpkg}
+local EMERGE_DEFAULT_ARGS=${2:---accept-properties=-interactive --verbose --oneshot --nospinner --noreplace --quiet-build=y --quiet-fail --fail-clean=y --complete-graph --buildpkg}
 for i in $(EIX_LIMIT=0 eix --only-names --pure-packages "$SEARCH/" | xargs echo | uniq);
   do
+    echo "Building $i"
     emerge $EMERGE_DEFAULT_ARGS -o $i && \
     emerge $EMERGE_DEFAULT_ARGS $i
   done
@@ -21,11 +22,11 @@ for i in $(EIX_LIMIT=0 eix --only-names --pure-packages "$SEARCH/" | xargs echo
 
 build_installed() {
   local SEARCH=$1
-  local EMERGE_DEFAULT_ARGS=${2:---accept-properties=-interactive --newuse --changed-use --update --verbose --oneshot --nospinner --quiet-build=y --quiet-fail --fail-clean=y --complete-graph --buildpkg}
+  local EMERGE_DEFAULT_ARGS=${2:---accept-properties=-interactive --newuse --noreplace --changed-use --update --verbose --oneshot --nospinner --quiet-build=y --quiet-fail --fail-clean=y --complete-graph --buildpkg}
 
   for i in $(EIX_LIMIT=0 eix -I --only-names --pure-packages "$SEARCH/" | xargs echo | uniq);
     do
-      #emerge $EMERGE_DEFAULT_ARGS -o $i && \
+      echo "Building $i"
       emerge $EMERGE_DEFAULT_ARGS $i
     done
 }