Fixed problems with various utilities.

git-svn-id: https://svn.code.sf.net/p/flaim/code/trunk@547 0109f412-320b-0410-ab79-c3e0c5ffbbe6

xflaim/src/flchktr.cpp

@@ -271,7 +271,6 @@ RCODE F_DbCheck::chkReportError(
 		m_uiFlags &= ~XFLM_DO_LOGICAL_CHECK;
 	}
 
-	flmAssert( 0);
 	return( m_LastStatusRc);
 }
 

xflaim/src/flverify.cpp

@@ -1183,6 +1183,8 @@ RCODE F_DbCheck::verifyBTrees(
 	F_BLK_HDR *						pBlkHdr = NULL;
 	F_CachedBlock *				pSCache = NULL;
 	
+	f_memset( State, 0, sizeof( State));
+
 	// The StateInfo structs may have pointer to this object,
 	// but we only need one instance, so do the new here, rather
 	// than inside the loop where we initialize the StateInfo structs.

xflaim/src/fslfileu.cpp

@@ -2604,9 +2604,7 @@ Exit:
 }
 
 /****************************************************************************
-Desc:		Thread that will build an index in the background.
-			Caller will create a pDb to use.  This pDb must be
-			freed at the conclusion of the routine.
+Desc:
 ****************************************************************************/
 RCODE F_Database::maintenanceThread(
 	IF_Thread *		pThread)
@@ -2656,16 +2654,9 @@ Retry:
 			}
 			bStartedTrans = TRUE;
 				
-			if( RC_BAD( rc = pDb->getDocument( 
+			if( RC_BAD( pDb->getDocument( 
 				XFLM_MAINT_COLLECTION, XFLM_INCL, ui64DocId, (IF_DOMNode **)&pDoc)))
 			{
-				if( rc != NE_XFLM_DOM_NODE_NOT_FOUND)
-				{
-					RC_UNEXPECTED_ASSERT( rc);
-					goto Exit;
-				}
-				
-				rc = NE_XFLM_OK;
 				break;
 			}
 			

xflaim/src/fsysdata.cpp

@@ -2062,14 +2062,6 @@ void F_DbSystem::cleanup( void)
 		gv_XFlmSysData.pCacheCleanupThrd = NULL;
 	}
 
-	// Release the thread manager
-
-	if( gv_XFlmSysData.pThreadMgr)
-	{
-		gv_XFlmSysData.pThreadMgr->Release();
-		gv_XFlmSysData.pThreadMgr = NULL;
-	}
-
 	// Free all of the files and associated structures
 
 	if (gv_XFlmSysData.pDatabaseHashTbl)
@@ -2165,6 +2157,14 @@ void F_DbSystem::cleanup( void)
 		}
 	}
 
+	// Release the thread manager
+
+	if( gv_XFlmSysData.pThreadMgr)
+	{
+		gv_XFlmSysData.pThreadMgr->Release();
+		gv_XFlmSysData.pThreadMgr = NULL;
+	}
+
 	// Release the file system object
 
 	if (gv_XFlmSysData.pFileSystem)

xflaim/util/view.cpp

@@ -60,7 +60,6 @@ FSTATIC FLMBOOL ViewOpenFileDirect( void);
 static FLMBOOL		bPauseBeforeExiting = FALSE;
 FLMUINT				gv_uiTopLine = 0;
 FLMUINT				gv_uiBottomLine = 0;
-IF_DbSystem *		gv_pDbSystem = NULL;
 
 /********************************************************************
 Desc: ?

xflaim/util/view.h

@@ -539,6 +539,12 @@ EXTERN VIEW_MENU_ITEM_p			gv_pViewMenuLastItem
 #endif
 	;
 
+EXTERN IF_DbSystem *				gv_pDbSystem
+#ifdef MAIN_MODULE
+	= NULL
+#endif
+	;
+
 // Function prototypes
 
 #ifdef FLM_NLM

xflaim/util/viewblk.cpp

@@ -316,15 +316,25 @@ FLMBOOL ViewBlkRead(
 			{
 				convert16( &ui16BlkBytesAvail);
 			}
-			uiBlkEnd = (blkIsNewBTree( pBlkHdr)
-							? gv_ViewDbHdr.ui16BlockSize
-							: gv_ViewDbHdr.ui16BlockSize - (FLMUINT)ui16BlkBytesAvail);
-			*pui32CalcCRC = calcBlkCRC( pBlkHdr, uiBlkEnd);
+
+			if( ui16BlkBytesAvail > gv_ViewDbHdr.ui16BlockSize)
+			{
+				*pui32CalcCRC = 0;
+			}
+			else
+			{
+				uiBlkEnd = (blkIsNewBTree( pBlkHdr)
+								? gv_ViewDbHdr.ui16BlockSize
+								: gv_ViewDbHdr.ui16BlockSize - (FLMUINT)ui16BlkBytesAvail);
+				*pui32CalcCRC = calcBlkCRC( pBlkHdr, uiBlkEnd);
+			}
 		}
+
 		if (blkIsNonNativeFormat( pBlkHdr))
 		{
 			convertBlk( (FLMUINT)gv_ViewDbHdr.ui16BlockSize, pBlkHdr);
 		}
+
 		if (pui32BlkCRC)
 		{
 			*pui32BlkCRC = pBlkHdr->ui32BlkCRC;

xflaim/util/viewmenu.cpp

@@ -180,7 +180,6 @@ FSTATIC void ViewDispMenuItem(
 	FLMUINT		uiCol = pMenuItem->uiCol;
 	FLMUINT		uiLoop;
 	char			szTempBuf [80];
-	F_DbSystem	dbSystem;
 
 	if (!gv_bViewEnabled)
 	{
@@ -288,7 +287,7 @@ FSTATIC void ViewDispMenuItem(
 		case VAL_IS_ERR_INDEX:
 			{
 			FLMUINT  ValIndex = (FLMUINT)pMenuItem->ui64Value;
-			f_conStrOutXY( dbSystem.checkErrorToStr( ValIndex),
+			f_conStrOutXY( gv_pDbSystem->checkErrorToStr( ValIndex),
 							uiCol, uiRow);
 			break;
 			}