Finished project self-review changes.

This commit is contained in:
Juan Carlos Luciani 2006-12-08 10:26:52 +00:00
parent 8ade751650
commit 245d0fe0bf
6 changed files with 22 additions and 4 deletions

View File

@ -179,13 +179,17 @@ ValidateAuthToken(
IdenTokenUninit();
PrincipalIfUninit();
ConfigIfUninit();
retStatus = CasaStatusBuild(CASA_SEVERITY_ERROR,
CASA_FACILITY_AUTHTOKEN,
CASA_STATUS_UNSUCCESSFUL);
}
else
{
if ((g_ipcInitPtr)("CASA_AuthTokenValidate",
g_multiThreadedApplication,
DebugLevel,
false) == 0)
true) == 0)
{
// Open endpoint for the Authentication Token Validation Service
//if ((g_ipcOpenEndPointPtr)(5000,
@ -206,6 +210,10 @@ ValidateAuthToken(
IdenTokenUninit();
PrincipalIfUninit();
ConfigIfUninit();
retStatus = CasaStatusBuild(CASA_SEVERITY_ERROR,
CASA_FACILITY_AUTHTOKEN,
CASA_STATUS_UNSUCCESSFUL);
}
}
else
@ -215,6 +223,10 @@ ValidateAuthToken(
IdenTokenUninit();
PrincipalIfUninit();
ConfigIfUninit();
retStatus = CasaStatusBuild(CASA_SEVERITY_ERROR,
CASA_FACILITY_AUTHTOKEN,
CASA_STATUS_UNSUCCESSFUL);
}
}
}

View File

@ -1,3 +1,8 @@
-------------------------------------------------------------------
Fri Dec 8 15:20:11 MST 2006 - jluciani@novell.com
- Made changes resulting from self-code review of the project.
-------------------------------------------------------------------
Mon Dec 4 15:15:44 MST 2006 - jluciani@novell.com

View File

@ -625,7 +625,7 @@ CChannel::connectionThread(
// Free SmartCChannel
delete pSmartCChannel;
DbgTrace(0, "CChannel::connectionThread- End\n", 0);
DbgTrace(1, "CChannel::connectionThread- End\n", 0);
// Exit
pthread_exit(NULL);

View File

@ -81,7 +81,7 @@ RemoteEndPoint::RemoteEndPoint(
DbgTrace(1, "RemoteEndPoint::RemoteEndPoint- Start, Obj = %0X\n", this);
// Verify that the specified path is not too long
if (strlen(pSocketFileName) < sizeof(sizeof(m_serverUnAddr.sun_path)))
if (strlen(pSocketFileName) < sizeof(m_serverUnAddr.sun_path))
{
// Initialize our mutex
pthread_mutex_init(&m_mutex, NULL);

View File

@ -25,6 +25,7 @@
//===[ Include files ]=====================================================
#define __STDC_LIMIT_MACROS
#include "ipcint.h"
//===[ External data ]=====================================================

View File

@ -437,7 +437,7 @@ BindSocket(int socketToBind)
unlink(listenSocketFile);
// Verify that the specified path is not too long
if (strlen(listenSocketFile) < sizeof(sizeof(listenAddr.sun_path)))
if (strlen(listenSocketFile) < sizeof(listenAddr.sun_path))
{
// Setup the address that the daemon will use to listen
// for connections.