From cd8bb3a63b4f38906501692fac9a12d2dfd7ea4b Mon Sep 17 00:00:00 2001
From: "(no author)" <(no author)@cd1c1023-2f26-0410-ae45-c471fc1f0318>
Date: Tue, 6 Nov 2007 22:57:23 +0000
Subject: [PATCH] fix two misc bugs

git-svn-id: http://svn.sabayonlinux.org/projects/entropy/trunk@622 cd1c1023-2f26-0410-ae45-c471fc1f0318
---
 libraries/databaseTools.py | 24 ++++++++++--------------
 libraries/reagentTools.py  |  1 +
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/libraries/databaseTools.py b/libraries/databaseTools.py
index 33952a5e3..f98745545 100644
--- a/libraries/databaseTools.py
+++ b/libraries/databaseTools.py
@@ -67,17 +67,17 @@ def database(options):
         # database file: etpConst['etpdatabasefilepath']
 	revisionsMatch = {}
         if os.path.isfile(etpConst['etpdatabasefilepath']):
-	    try:
-		dbconn = openServerDatabase(readOnly = True, noUpload = True)
-		idpackages = dbconn.listAllIdpackages()
-		for idpackage in idpackages:
+	    dbconn = openServerDatabase(readOnly = True, noUpload = True)
+	    idpackages = dbconn.listAllIdpackages()
+	    for idpackage in idpackages:
+		try:
 		    package = os.path.basename(dbconn.retrieveDownloadURL(idpackage))
 		    branch = dbconn.retrieveBranch(idpackage)
 		    revision = dbconn.retrieveRevision(idpackage)
 		    revisionsMatch[package] = [branch,revision]
-		dbconn.closeDB()
-	    except:
-		pass
+		except:
+		    pass
+	    dbconn.closeDB()
 	    print_info(red(" * ")+bold("WARNING")+red(": database file already exists. Overwriting."))
 	    rc = entropyTools.askquestion("\n     Do you want to continue ?")
 	    if rc == "No":
@@ -529,12 +529,8 @@ def openClientDatabase(xcache = True):
    @output: database pointer or, -1 if error
 '''
 def openServerDatabase(readOnly = True, noUpload = True):
-    
-    if os.path.isfile(etpConst['etpdatabasefilepath']):
-        conn = etpDatabase(readOnly = readOnly, dbFile = etpConst['etpdatabasefilepath'], noUpload = noUpload)
-	return conn
-    else:
-	raise Exception,"openServerDatabase: database not found. You must generate it first."
+    conn = etpDatabase(readOnly = readOnly, dbFile = etpConst['etpdatabasefilepath'], noUpload = noUpload)
+    return conn
 
 # this class simply describes the current database status
 # FIXME: need a rewrite? simply using dicts, perhaps?
@@ -3046,7 +3042,7 @@ class etpDatabase:
 	if branch:
 	    branchstring = ' where branch = "'+branch+'"'
 	self.cursor.execute('SELECT idpackage FROM baseinfo'+branchstring)
-	return self.cursor.fetchall()
+	return self.fetchall2set(self.cursor.fetchall())
 
     def listAllDependencies(self):
 	dbLog.log(ETP_LOGPRI_INFO,ETP_LOGLEVEL_VERBOSE,"listAllDependencies: called.")
diff --git a/libraries/reagentTools.py b/libraries/reagentTools.py
index 20ab2b3a1..bffe9fb3e 100644
--- a/libraries/reagentTools.py
+++ b/libraries/reagentTools.py
@@ -142,6 +142,7 @@ def update(options):
 	        if (not match):
 	            # check if the package is in toBeAdded
 	            if (toBeAdded):
+			print x
 	                atomkey = dep_getkey(dbconn.retrieveAtom(x[1]))
 		        atomslot = dbconn.retrieveSlot(x[1])
 		        add = True