From a8724df5d282c4bffe663d70598b0b4e6f04126f Mon Sep 17 00:00:00 2001 From: ChatGPT Date: Thu, 18 Jun 2026 11:02:51 +0000 Subject: [PATCH] nwnss: audit COMN xaction and helper imports --- nwnss-audit.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/nwnss-audit.md b/nwnss-audit.md index ac6139a..846df33 100644 --- a/nwnss-audit.md +++ b/nwnss-audit.md @@ -34,9 +34,9 @@ Status legend: Current inventory summary: -- `AUDITED`: 415 files +- `AUDITED`: 421 files - `PARTIAL`: 18 files -- `TODO`: 88 files +- `TODO`: 82 files - `TEMP`: 4 files - Total listed files: 525 @@ -506,16 +506,16 @@ even if it already compiles or has indirect test coverage. | AUDITED | ORIG+FIX | nwnss.unicode, nwnss.namespace | `src/nwnss/comn/common/comnUnicode.c` | Compared with original `public_core/comn/common/comnUnicode.c`; COMN_NameToUnicode, COMN_UnicodeToName, COMN_UnicodeToLPName and COMN_LPNameToUnicode logic is unchanged. The only source change is dropping the kernel-only `linux/module.h` include for the userspace build; conversion behavior is covered through nwnss.unicode/nwnss.namespace and the generated unitable loader. | | AUDITED | ORIG+FIX | nwnss.namespace | `src/nwnss/comn/common/comnVariableData.c` | Compared with original `public_core/comn/common/comnVariableData.c`; root variable-data registry, pack/unpack/free/XML dispatch logic is unchanged. Mars keeps whitespace cleanup and the intentional bounds fix from 0572 (`rvdType >= RVD_MAX_ELEMENTS`) so the array-length constant is rejected instead of indexing one element past `RVD_functions`; invalid, valid and duplicate registration paths plus pack/free behavior are covered by nwnss.namespace. | | AUDITED | ORIG+FIX | link smoke, future volume tests | `src/nwnss/comn/common/comnVol.c` | Compared with original `public_core/comn/common/comnVol.c`; volume event definitions, setup/cleanup, alert work scheduling, active-list lookup/iteration and volume accounting helpers are kept. Differences are whitespace cleanup plus a modern `WORK_Schedule` cast for the alert work routine; no volume-active shortcut or fake pool/volume state is introduced. | -| TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/comnWild.c` | Must be compared against original source and classified. | -| TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/comnXaction.c` | Must be compared against original source and classified. | -| TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/contextHandle.c` | Must be compared against original source and classified. | -| TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/cro.c` | Must be compared against original source and classified. | +| AUDITED | ORIG+FIX | link smoke, future wildcard tests | `src/nwnss/comn/common/comnWild.c` | Compared with original `public_core/comn/common/comnWild.c`; wildcard/read/restart control flow is unchanged in the current import. No userspace compatibility shim, storage shortcut or namespace behavior change was found beyond the import path itself. | +| AUDITED | ORIG+FIX | link smoke, future xaction tests | `src/nwnss/comn/common/comnXaction.c` | Compared with original `public_core/comn/common/comnXaction.c`; begin/end XLocal, force-write and xaction latch/control flow are unchanged in the current import. This confirms the earlier temporary xlocal bridge was replaced by the real original file rather than a synthetic base split. | +| AUDITED | ORIG+FIX | link smoke, future handle tests | `src/nwnss/comn/common/contextHandle.c` | Compared with original `public_core/comn/common/contextHandle.c`; context-handle lookup, resolve, release and message integration logic is unchanged in the current import. No userspace-specific shortcut was introduced. | +| AUDITED | ORIG+FIX/PORT | link smoke, future CRO tests | `src/nwnss/comn/common/cro.c` | Compared with original `public_core/comn/common/cro.c`; child/reference-object message and lease control flow is kept. Userspace difference is limited to `stdint.h` visibility plus the local `SetErrnoFromStatus` bridge because `Msg_s.sys.where` is carried as a `QUAD` in the imported userspace message ABI. | | AUDITED | ORIG+FIX/PORT | link smoke | `src/nwnss/comn/common/csaLease.c` | Compared with original `public_core/comn/common/csaLease.c`; CSA lease-list logic is kept. Userspace differences drop `linux/module.h`, normalize local includes to imported headers, add `stdint.h`, and cast `msg->sys.data[0].start` through `uintptr_t` before treating the QUAD transport field as an `XLSSBeastLeaseList_s *`. | | AUDITED | ORIG+FIX | link smoke, future dirquota behavior tests | `src/nwnss/comn/common/dirQuotas.c` | Compared with original `public_core/comn/common/dirQuotas.c`; directory-quota accounting and scheduling logic are kept. Userspace differences drop `linux/module.h` and cast `WORK_Schedule` callbacks/arguments for modern function-pointer prototypes; remaining changes are whitespace cleanup. | -| TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/eflMgmt.c` | Must be compared against original source and classified. | +| AUDITED | ORIG+FIX | link smoke, future EFL tests | `src/nwnss/comn/common/eflMgmt.c` | Compared with original `public_core/comn/common/eflMgmt.c`; encrypted-file-list management logic is unchanged in the current import. No userspace-specific code or behavior shortcut was found. | | TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/fileHandle.c` | Must be compared against original source and classified. | | TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/fsmsg.c` | Must be compared against original source and classified. | -| TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/hardLinkBeast.c` | Must be compared against original source and classified. | +| AUDITED | ORIG+FIX | link smoke, future hardlink tests | `src/nwnss/comn/common/hardLinkBeast.c` | Compared with original `public_core/comn/common/hardLinkBeast.c`; hard-link beast handling is unchanged in the current import. No userspace-specific code or fake hardlink path was found. | | PARTIAL | ORIG+FIX / KERNEL-BOUNDARY | compile-smoke only | `src/nwnss/comn/common/hmc.c` | Compared against `public_core/comn/common/hmc.c`; main file body is original high-memory metadata cache code. Mars adds a `MARS_NWE_NWNSS_USERSPACE` shim for Linux slab/page/highmem/inode APIs and keeps host libc allocation prototypes local to that shim. Needs later full HMC behavior tests before AUDITED. | | PARTIAL | ORIG wrapper | link smoke | `src/nwnss/comn/common/mgmt.c` | Wrapper compiles mgmt.c.h; full original diff open. | | TODO | ORIG+FIX? | not yet classified | `src/nwnss/comn/common/mgmtFiles.c` | Must be compared against original source and classified. |