From 336b2ce73e7a34587431acd918d8e2b3872c99a0 Mon Sep 17 00:00:00 2001 From: OpenAI Date: Sat, 30 May 2026 15:57:12 +0000 Subject: [PATCH] tests: allow absent AFP-only attribute xattr in suite After aligning AFP Set File Information with the WebSDK attribute word, Hidden, System, and Archive are represented by the existing NetWare attribute store instead of org.mars-nwe.afp.attributes. The default smoke path can therefore legitimately have no AFP-only attribute xattr once those bits are cleared or mapped away. Update afp_smoke_suite.sh to treat the AFP-only attributes xattr dump as optional while still reporting the getfattr output. FinderInfo and Entry ID xattrs remain mandatory because they are still AFP-specific metadata stores. Tests: bash -n tests/linux/afp_smoke_suite.sh --- tests/linux/afp_smoke_suite.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/linux/afp_smoke_suite.sh b/tests/linux/afp_smoke_suite.sh index b30bdd2..097e9c1 100755 --- a/tests/linux/afp_smoke_suite.sh +++ b/tests/linux/afp_smoke_suite.sh @@ -442,10 +442,11 @@ if command -v getfattr >/dev/null 2>&1; then "getfattr -n user.org.mars-nwe.afp.finder-info -e hex '$UNIX_PATH'" \ getfattr -n user.org.mars-nwe.afp.finder-info -e hex "$UNIX_PATH" - run_cmd \ - "Linux xattr: AFP Attributes" \ + run_optional_cmd \ + "Linux xattr: AFP Attributes (optional AFP-only bits)" \ "getfattr -n user.org.mars-nwe.afp.attributes -e hex '$UNIX_PATH'" \ - getfattr -n user.org.mars-nwe.afp.attributes -e hex "$UNIX_PATH" + getfattr -n user.org.mars-nwe.afp.attributes -e hex "$UNIX_PATH" || \ + emit "AFP-only attributes xattr is absent; this is expected when the tested Hidden/System/Archive bits are stored through the NetWare attribute path." run_cmd \ "Linux xattr: AFP Entry ID" \