diff --git a/TODO.md b/TODO.md index 0756af0..2858dce 100644 --- a/TODO.md +++ b/TODO.md @@ -256,8 +256,8 @@ Current status: `TEXT` and creator `MARS`. The helper writes 32 bytes of FinderInfo to `org.mars-nwe.afp.finder-info`, stores the narrow attribute word in `org.mars-nwe.afp.attributes`, and verifies the result through AFP 2.0 Get - File Information. The smoke-suite report helper now includes AFP 2.0 FinderInfo, legacy AFP `0x09` FinderInfo, plus Invisible/System/Backup set/clear probes - and has a green + File Information. The smoke-suite report helper now includes AFP 2.0 FinderInfo, legacy AFP `0x09` FinderInfo, AFP 2.0 Invisible/System/Backup set/clear probes, + and legacy AFP `0x09` Invisible set/clear probes, and has a green `failures=0` run for `SYS:PUBLIC/pmdflts.ini`; that run confirms the corrected FinderInfo payload alignment by reading `user.org.mars-nwe.afp.finder-info=0x544558544d415253...` (`TEXTMARS` with no diff --git a/tests/linux/README.md b/tests/linux/README.md index fbf0aff..0734fbb 100644 --- a/tests/linux/README.md +++ b/tests/linux/README.md @@ -57,8 +57,9 @@ Example from the build `tests/linux` directory: The report includes AFP Entry ID, Entry ID From NetWare Handle, Get File Information, Scan File Information, Alloc Temporary Directory Handle, Open File Fork, FinderInfo Set File Information for both AFP 2.0 (`0x10`) and the legacy AFP -Set File Information (`0x09`), Invisible/System/Backup Set/Clear File -Information, and the Linux xattr checks for: +Set File Information (`0x09`), AFP 2.0 Invisible/System/Backup Set/Clear File +Information, legacy AFP `0x09` Invisible Set/Clear coverage, and the Linux xattr +checks for: ```text user.org.mars-nwe.afp.finder-info @@ -69,6 +70,8 @@ user.org.mars-nwe.afp.entry-id The suite now also exercises the additional metadata-only AFP attribute bits that `afp_set_file_info_smoke` supports: System (`0x0004`) and Backup (`0x0040`). +It additionally runs the legacy AFP `0x09` path for the Invisible attribute so +both Set File Information entry points cover FinderInfo and attribute writes. It clears both again before the final xattr dump so repeated runs leave the attribute payload in the clean `0x01000000` state unless a previous command fails. diff --git a/tests/linux/afp_smoke_suite.sh b/tests/linux/afp_smoke_suite.sh index 0dd80a4..b2a9499 100755 --- a/tests/linux/afp_smoke_suite.sh +++ b/tests/linux/afp_smoke_suite.sh @@ -253,6 +253,18 @@ run_cmd \ "$SCRIPT_DIR/afp_set_file_info_smoke" -S "$SERVER" -U "$USER_NAME" -P "$PASSWORD" \ --attributes-only --clear-invisible "$NETWARE_PATH" +run_cmd \ + "AFP Set File Information Invisible legacy" \ + "./afp_set_file_info_smoke $COMMON_PRINT --afp09 --attributes-only --invisible '$NETWARE_PATH'" \ + "$SCRIPT_DIR/afp_set_file_info_smoke" -S "$SERVER" -U "$USER_NAME" -P "$PASSWORD" \ + --afp09 --attributes-only --invisible "$NETWARE_PATH" + +run_cmd \ + "AFP Set File Information Clear Invisible legacy" \ + "./afp_set_file_info_smoke $COMMON_PRINT --afp09 --attributes-only --clear-invisible '$NETWARE_PATH'" \ + "$SCRIPT_DIR/afp_set_file_info_smoke" -S "$SERVER" -U "$USER_NAME" -P "$PASSWORD" \ + --afp09 --attributes-only --clear-invisible "$NETWARE_PATH" + run_cmd \ "AFP Set File Information System" \ "./afp_set_file_info_smoke $COMMON_PRINT --attributes-only --system '$NETWARE_PATH'" \