mars_nwe/mars-dosutils
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ncpcalls: use descriptive names for NCP wrapper functions

Browse Source 
Rename the low-level NCP wrapper functions in ncpcall.c and net.h to include
both the NCP function/subfunction number and the operation they perform.

This keeps the numeric protocol reference visible for comparison with SDK
documentation and MARS-NWE logs, while making call sites easier to understand.
Update all callers to use the new names.

No behavior change.
This commit is contained in:
Mario Fetka
2026-05-29 09:55:33 +02:00
parent 19afe23651
commit 53e28c6bfe
12 changed files with 54 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
nwtests.c
View File

@@ -2506,10 +2506,10 @@ static int tests_effright(char *path)
{
int access_level;
access_level = ncp_14_46(&my_obj_id);
access_level = ncp17_46_get_bindery_access_level(&my_obj_id);
my_obj_name[0] = '\0';
if (access_level >= 0 && my_obj_id) {
ncp_17_36(my_obj_id, my_obj_name, &my_obj_type);
ncp17_36_get_bindery_object_name(my_obj_id, my_obj_name, &my_obj_type);
fprintf(stdout, "Current object: %08lX type=%04X access=%02X name=%s\n\n",
(unsigned long)my_obj_id, my_obj_type,
(unsigned)access_level, my_obj_name);
@@ -2586,7 +2586,7 @@ static int tests_effright(char *path)
if (usepath[0]) {
int subdir = 1;
int r = ncp_16_02(dhandle, (uint8 *)usepath, &subdir,
int r = ncp16_02_get_directory_entry(dhandle, (uint8 *)usepath, &subdir,
NULL, NULL, NULL);
if (r >= 0)
tests_print_eff_row("ncp16_02 parent", 0, (uint8)r, (uint16)r, 1);