Security Audit. Checkpoint changes thus far to c code.
This commit is contained in:
@@ -45,7 +45,7 @@ extern "C"
|
||||
void* sscs_CacheOpenSecretStore
|
||||
(
|
||||
void *secretStoreID,
|
||||
uint32_t ssFlags,
|
||||
uint32_t ssFlags,
|
||||
void *reserved
|
||||
|
||||
)
|
||||
@@ -54,27 +54,19 @@ void* sscs_CacheOpenSecretStore
|
||||
SSCS_LINUX_SS_HANDLE_T *platHandle = NULL;
|
||||
int32_t retVal = 0;
|
||||
|
||||
ssHandle = (SSCS_SECRETSTORE_HANDLE_T *)malloc(sizeof(SSCS_SECRETSTORE_HANDLE_T));
|
||||
ssHandle = (SSCS_SECRETSTORE_HANDLE_T *)malloc((sizeof(SSCS_SECRETSTORE_HANDLE_T) + (sizeof(SSCS_LINUX_SS_HANDLE_T))));
|
||||
if(NULL == ssHandle)
|
||||
{
|
||||
return NULL;
|
||||
}
|
||||
|
||||
platHandle = (SSCS_LINUX_SS_HANDLE_T *)malloc(sizeof(SSCS_LINUX_SS_HANDLE_T));
|
||||
if(NULL == platHandle)
|
||||
{
|
||||
free(ssHandle);
|
||||
return NULL;
|
||||
}
|
||||
memset(ssHandle,0,sizeof(SSCS_SECRETSTORE_HANDLE_T));
|
||||
memset(platHandle,0,sizeof(SSCS_LINUX_SS_HANDLE_T));
|
||||
|
||||
ssHandle->platHandle = platHandle;
|
||||
|
||||
memset(ssHandle,0,sizeof(SSCS_SECRETSTORE_HANDLE_T));
|
||||
ssHandle->platHandle = ssHandle + sizeof(SSCS_SECRETSTORE_HANDLE_T);
|
||||
|
||||
retVal = ipc_OpenSecretStore(secretStoreID,ssHandle);
|
||||
if(retVal)
|
||||
{
|
||||
free(platHandle);
|
||||
memset(ssHandle, 0, sizeof(SSCS_SECRETSTORE_HANDLE_T) + (sizeof(SSCS_LINUX_SS_HANDLE_T)));
|
||||
free(ssHandle);
|
||||
return NULL;
|
||||
}
|
||||
@@ -106,8 +98,7 @@ int32_t sscs_CacheCloseSecretStore
|
||||
|
||||
if(ssHandleCopy->platHandle)
|
||||
{
|
||||
retVal = ipc_CloseSecretStore(ssHandleCopy, ssFlags);
|
||||
free(ssHandleCopy->platHandle);
|
||||
retVal = ipc_CloseSecretStore(ssHandleCopy, ssFlags);
|
||||
}
|
||||
|
||||
if(ssHandleCopy)
|
||||
|
||||
Reference in New Issue
Block a user