Modifications to resolve issues found during self-code review.

CASA-auth-token/server/utilities/IpcLibs/linux/client/client.cpp

@@ -354,8 +354,6 @@ IpcClientCloseRemoteEndPoint(
       DbgTrace(0, "IpcClientCloseRemoteEndPoint- Not initialized\n", 0);
    }
 
-exit:
-
    DbgTrace(1, "IpcClientCloseRemoteEndPoint- End, status = %0X\n", retStatus);
 
    return retStatus;
@@ -368,9 +366,9 @@ int
 IpcClientSubmitReq(
    IN uint32_t endPointHandle,
    IN char *pClientData,
-   IN int clientDataLen,
+   IN int32_t clientDataLen,
    INOUT char **ppServerData,
-   INOUT int *pServerDataLen)
+   INOUT int32_t *pServerDataLen)
 //
 // Arguments In:  endPointHandle - Handle of the remote endpoint that will
 //                                 be the target of the request.
@@ -410,6 +408,15 @@ IpcClientSubmitReq(
 
    DbgTrace(1, "IpcClientSubmitReq- Start\n", 0);
 
+   // Verify input parameters
+   if (pClientData == NULL
+       || ppServerData == NULL
+       || pServerDataLen == NULL)
+   {
+      DbgTrace(0, "IpcClientSubmitReq- Invalid parameter\n", 0);
+      goto exit;
+   }
+
    // Verify that we have been initialized
    if (svcInitialized)
    {
@@ -425,7 +432,7 @@ IpcClientSubmitReq(
          // the request.
          SmartRemoteEndPoint *pSmartRemoteEndPoint = new SmartRemoteEndPoint(*(iter->second));
 
-         // Release our mutex before deleting the endpoint
+         // Release our mutex before using the remote endpoint
          pthread_mutex_unlock(&clientMutex);
 
          // Submit the request
@@ -450,6 +457,8 @@ IpcClientSubmitReq(
       DbgTrace(0, "IpcClientSubmitReq- Not initialized\n", 0);
    }
 
+exit:
+
    DbgTrace(1, "IpcClientSubmitReq- End, retStatus = %0X\n", retStatus);
 
    return retStatus;
@@ -498,7 +507,7 @@ IpcClientInit(
    DbgTrace(1, "IpcClientInit- Start\n", 0);
 
    // Check input parameters
-   if (pAppName == NULL)
+   if (pName == NULL)
    {
       DbgTrace(0, "IpcClientInit- Invalid parameter\n", 0);
       goto exit;