Changes to address issues brought up by the security review.
This commit is contained in:
		@@ -234,10 +234,10 @@ SChannel::connectionThread(
 | 
			
		||||
{
 | 
			
		||||
   SChannel       *pSChannel = *pSmartSChannel;
 | 
			
		||||
   bool           doneReceivingData = false;
 | 
			
		||||
   int32_t        bytesReceived;
 | 
			
		||||
   size_t         bytesReceived;
 | 
			
		||||
   unsigned long  bytesSent;
 | 
			
		||||
   uint32_t       reqId;
 | 
			
		||||
   int32_t        payloadLength;
 | 
			
		||||
   uint32_t       payloadLength;
 | 
			
		||||
   unsigned long  totalPayloadBytesReceived = 0;
 | 
			
		||||
   char           reqDataPktHdr[ReqDataPktHdrTemplate.length()];
 | 
			
		||||
   char           reqErrorPktHdr[ReqErrorPktHdrTemplate.length()];
 | 
			
		||||
@@ -520,7 +520,7 @@ int
 | 
			
		||||
SChannel::sendReplyData(
 | 
			
		||||
   uint32_t reqId,
 | 
			
		||||
   char *pServerData,
 | 
			
		||||
   int32_t serverDataLen)
 | 
			
		||||
   uint32_t serverDataLen)
 | 
			
		||||
//
 | 
			
		||||
//  Arguments: 
 | 
			
		||||
//
 | 
			
		||||
 
 | 
			
		||||
@@ -150,7 +150,7 @@ public:
 | 
			
		||||
   //
 | 
			
		||||
   int sendReplyData(uint32_t reqId,
 | 
			
		||||
                     char *pServerData,
 | 
			
		||||
                     int32_t serverDataLen);
 | 
			
		||||
                     uint32_t serverDataLen);
 | 
			
		||||
 | 
			
		||||
   //
 | 
			
		||||
   // Send Reply Error routine
 | 
			
		||||
 
 | 
			
		||||
@@ -847,7 +847,7 @@ IpcServerGetRequestData(
 | 
			
		||||
// L2
 | 
			
		||||
//=======================================================================--
 | 
			
		||||
{
 | 
			
		||||
   int32_t  reqDataLen = 0;
 | 
			
		||||
   uint32_t reqDataLen = 0;
 | 
			
		||||
 | 
			
		||||
   DbgTrace(1, "IpcServerGetRequestData- Start, requestId = %0X\n", requestId);
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -61,7 +61,7 @@ ServerReq::ServerReq(
 | 
			
		||||
   SChannel *pSChannel,
 | 
			
		||||
   uint32_t reqId,
 | 
			
		||||
   char *pClientData,
 | 
			
		||||
   int32_t clientDataLength) :
 | 
			
		||||
   uint32_t clientDataLength) :
 | 
			
		||||
 | 
			
		||||
   m_signature (SERVER_REQ_SIGNATURE),
 | 
			
		||||
   m_reqId (reqId),
 | 
			
		||||
@@ -125,7 +125,7 @@ ServerReq::~ServerReq(void)
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
//++=======================================================================
 | 
			
		||||
int
 | 
			
		||||
uint32_t
 | 
			
		||||
ServerReq::getReqData(
 | 
			
		||||
   char **ppClientData)
 | 
			
		||||
//
 | 
			
		||||
 
 | 
			
		||||
@@ -58,7 +58,7 @@ class ServerReq
 | 
			
		||||
 | 
			
		||||
   // Request Client Data
 | 
			
		||||
   char                    *m_pClientData;
 | 
			
		||||
   int32_t                 m_clientDataLength;
 | 
			
		||||
   uint32_t                m_clientDataLength;
 | 
			
		||||
 | 
			
		||||
public:
 | 
			
		||||
 | 
			
		||||
@@ -90,7 +90,7 @@ public:
 | 
			
		||||
   ServerReq(SChannel *pSChannel,
 | 
			
		||||
             uint32_t reqId,
 | 
			
		||||
             char *pClientData,
 | 
			
		||||
             int32_t clientDataLength);
 | 
			
		||||
             uint32_t clientDataLength);
 | 
			
		||||
 | 
			
		||||
   //
 | 
			
		||||
   // Get request Data routine
 | 
			
		||||
@@ -105,7 +105,7 @@ public:
 | 
			
		||||
   //
 | 
			
		||||
   // Returns: The length of the client request data. 0 if not successful.
 | 
			
		||||
   //
 | 
			
		||||
   int getReqData(char **ppClientData);
 | 
			
		||||
   uint32_t getReqData(char **ppClientData);
 | 
			
		||||
 | 
			
		||||
   //
 | 
			
		||||
   // Complete Request routine
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user