geos_one/CASA
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Security Audit 5.6: Check length of ssNameLen < 256 before allocating buffer.

Browse Source
This commit is contained in:
Jim Norman
2006-04-26 17:03:11 +00:00
parent 43a64f3df3
commit 315e2cecc1
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CASA.changes
View File

@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Wed Apr 26 11:02:00 MST 2006 - jnorman@novell.com
- Security Audit 5.6: Check length of ssNameLen < 256
before allocating buffer
------------------------------------------------------------------- -------------------------------------------------------------------
Wed Apr 26 10:55:20 MST 2006 - jnorman@novell.com Wed Apr 26 10:55:20 MST 2006 - jnorman@novell.com
- Security Audit 5.4: Issue Garbage Collect after loading persistence. - Security Audit 5.4: Issue Garbage Collect after loading persistence.

6
c_micasad/verbs/OpenSecretStore.cs
View File

@@ -50,6 +50,8 @@ namespace sscs.verbs
private byte[] outBuf; private byte[] outBuf;
int retCode = 0; int retCode = 0;
private static int MAX_SS_NAME_LEN = 256;
/* /*
* This method sets the class member with the byte array received. * This method sets the class member with the byte array received.
*/ */
@@ -81,11 +83,13 @@ namespace sscs.verbs
ssVersion = BitConverter.ToUInt32(inBuf,6); ssVersion = BitConverter.ToUInt32(inBuf,6);
ssNameLen = BitConverter.ToUInt32(inBuf,10); ssNameLen = BitConverter.ToUInt32(inBuf,10);
if (ssNameLen > MAX_SS_NAME_LEN)
throw new FormatException(" SecretStore Name length exceeds length allowed");
byte[] tempArr = new byte[ssNameLen]; byte[] tempArr = new byte[ssNameLen];
Array.Copy(inBuf,14,tempArr,0,ssNameLen); Array.Copy(inBuf,14,tempArr,0,ssNameLen);
ssName = Encoding.UTF8.GetString(tempArr); ssName = Encoding.UTF8.GetString(tempArr);
try try
{ {
SecretStore ss = SessionManager.CreateUserSession(userId); SecretStore ss = SessionManager.CreateUserSession(userId);