Applied changes to issues found during code review of the Svc component.
This commit is contained in:
@@ -47,7 +47,7 @@ import com.novell.casa.authtoksvc.CasaIdentityToken;
|
||||
* infrastructure.
|
||||
*
|
||||
*/
|
||||
public class CasaLoginModule implements LoginModule
|
||||
public final class CasaLoginModule implements LoginModule
|
||||
{
|
||||
private final static String casaUsername = "CasaIdentityUser";
|
||||
|
||||
|
||||
@@ -35,12 +35,12 @@ import com.novell.casa.authtoksvc.IdentityToken;
|
||||
* identities authenticated by Casa.
|
||||
*
|
||||
*/
|
||||
public class CasaPrincipal implements Principal
|
||||
public final class CasaPrincipal implements Principal
|
||||
{
|
||||
private String m_name;
|
||||
private String m_realm;
|
||||
private String m_identStoreUrl;
|
||||
private javax.naming.directory.Attributes m_attributes;
|
||||
private final String m_name;
|
||||
private final String m_realm;
|
||||
private final String m_identStoreUrl;
|
||||
private final javax.naming.directory.Attributes m_attributes;
|
||||
|
||||
/*
|
||||
* Constructor
|
||||
@@ -58,7 +58,7 @@ public class CasaPrincipal implements Principal
|
||||
* (non-Javadoc)
|
||||
* @see java.security.Principal#getName()
|
||||
*/
|
||||
public String getName()
|
||||
public final String getName()
|
||||
{
|
||||
return m_name;
|
||||
}
|
||||
@@ -66,7 +66,7 @@ public class CasaPrincipal implements Principal
|
||||
/*
|
||||
* Returns the name associated with the source of the identity data.
|
||||
*/
|
||||
public String getRealm()
|
||||
public final String getRealm()
|
||||
{
|
||||
return m_realm;
|
||||
}
|
||||
@@ -74,7 +74,7 @@ public class CasaPrincipal implements Principal
|
||||
/*
|
||||
* Returns the url associated with the source of the identity data.
|
||||
*/
|
||||
public String getIdentStoreUrl()
|
||||
public final String getIdentStoreUrl()
|
||||
{
|
||||
return m_identStoreUrl;
|
||||
}
|
||||
@@ -82,7 +82,7 @@ public class CasaPrincipal implements Principal
|
||||
/*
|
||||
* Returns the identity attributes.
|
||||
*/
|
||||
public javax.naming.directory.Attributes getAttributes()
|
||||
public final javax.naming.directory.Attributes getAttributes()
|
||||
{
|
||||
return m_attributes;
|
||||
}
|
||||
|
||||
@@ -44,7 +44,7 @@ import com.novell.casa.jaas.CasaPrincipal;
|
||||
* This is a sample application which demonstrates the use of
|
||||
* JAAS and Casa to authenticate a connection.
|
||||
*/
|
||||
public class SampleApp
|
||||
public final class SampleApp
|
||||
{
|
||||
/**
|
||||
* @param args
|
||||
|
||||
@@ -33,9 +33,9 @@ import javax.security.auth.callback.PasswordCallback;
|
||||
import javax.security.auth.callback.UnsupportedCallbackException;
|
||||
|
||||
|
||||
public class SampleAppCallbackHandler implements CallbackHandler
|
||||
public final class SampleAppCallbackHandler implements CallbackHandler
|
||||
{
|
||||
private String m_authToken;
|
||||
private final String m_authToken;
|
||||
|
||||
/*
|
||||
* Constructor
|
||||
@@ -46,7 +46,7 @@ public class SampleAppCallbackHandler implements CallbackHandler
|
||||
m_authToken = authToken;
|
||||
}
|
||||
|
||||
public void handle(Callback[] callbacks) throws IOException, UnsupportedCallbackException
|
||||
public final void handle(Callback[] callbacks) throws IOException, UnsupportedCallbackException
|
||||
{
|
||||
for (int i = 0; i < callbacks.length; i++)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user