-------------------------------------------------------------------
Thu May 4 17:38:25 IST 2006 - smanojna@novell.com - Description: 1. Fixed Bug 170854: CASAGui only allows one edit at a time. 2. Added 512 character limit during the edit operation, i.e. the newly edited value string cannot be longer than 512. 3. Fixed a bug caused during deleting and adding new key-value pairs, this bug had not been filed in Bugzilla. -In the manage secret dialog, delete a key-value pair. -Add a new key with the same name as the one deleted above but but with a different value. -When you click the OK button the changes are not effected. - Modified files: c_gui/MiCasa.cs c_gui/Firefox.cs c_gui/GnomeKeyring.cs c_gui/KdeWallet.cs c_gui/Common.cs -------------------------------------------------------------------
This commit is contained in:
		
							
								
								
									
										21
									
								
								CASA.changes
									
									
									
									
									
								
							
							
						
						
									
										21
									
								
								CASA.changes
									
									
									
									
									
								
							| @@ -1,3 +1,24 @@ | ||||
| ------------------------------------------------------------------- | ||||
| Thu May  4 17:38:25 IST 2006 - smanojna@novell.com | ||||
|  | ||||
| - Description: | ||||
|   1. Fixed Bug 170854: CASAGui only allows one edit at a time.   | ||||
|   2. Added 512 character limit during the edit operation, i.e. | ||||
|      the newly edited value string cannot be longer than 512. | ||||
|   3. Fixed a bug caused during deleting and adding new key-value pairs, | ||||
|      this bug had not been filed in Bugzilla. | ||||
|      -In the manage secret dialog, delete a key-value pair. | ||||
|      -Add a new key with the same name as the one deleted above but | ||||
|       but with a different value. | ||||
|      -When you click the OK button the changes are not effected.  | ||||
|  | ||||
| - Modified files: | ||||
|   c_gui/MiCasa.cs | ||||
|   c_gui/Firefox.cs | ||||
|   c_gui/GnomeKeyring.cs | ||||
|   c_gui/KdeWallet.cs | ||||
|   c_gui/Common.cs | ||||
|  | ||||
| ------------------------------------------------------------------- | ||||
| Thu May  4 15:23:17 IST 2006 - smanojna@novell.com | ||||
|  | ||||
|   | ||||
| @@ -59,6 +59,7 @@ public class Common | ||||
|   	public static string 	GladeFile			= null, | ||||
|   					DebugLogFile			= null; | ||||
|   | ||||
|  	public static int 	 	MAX_LEN 	= 512; | ||||
|  	 | ||||
|   	///############################################################## | ||||
|   	/// SPI CONSTANTS | ||||
|   | ||||
| @@ -323,7 +323,7 @@ public class Firefox : Store | ||||
| 							break; | ||||
| 						} | ||||
| 					} | ||||
| 					AggregateStore(); | ||||
| 					//AggregateStore(); | ||||
| 				} | ||||
| 				else | ||||
| 					Logger.DbgLog("GUI:Firefox.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); | ||||
|   | ||||
| @@ -338,7 +338,7 @@ public class GnomeKeyring : Store | ||||
| 			 | ||||
| 			if( false == entrySecretID.Editable ) | ||||
| 			{ | ||||
| 				if( ("" != args.NewText) && (KeyValue != args.NewText) ) | ||||
| 				if( ("" != args.NewText) && (Common.MAX_LEN >= args.NewText.Length) && (KeyValue != args.NewText) ) | ||||
| 				if(  Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_GNOMEKEYRING, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) ) | ||||
| 				{ | ||||
| 					Logger.DbgLog("GUI:GnomeKeyring.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded"); | ||||
| @@ -358,7 +358,7 @@ public class GnomeKeyring : Store | ||||
| 							break; | ||||
| 						} | ||||
| 					} | ||||
| 					AggregateStore(); | ||||
| 					//AggregateStore(); | ||||
| 				} | ||||
| 				else | ||||
| 					Logger.DbgLog("GUI:GnomeKeyring.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); | ||||
| @@ -585,7 +585,6 @@ public class GnomeKeyring : Store | ||||
| 						Logger.DbgLog("GUI:GnomeKeyring.on_buttonManageOk_clicked() - DELETE_KEY_FAILED.");	 | ||||
| 				} | ||||
| 				arrDeletedKeys.Clear();							 | ||||
| 				AggregateStore();			 | ||||
| 			}			 | ||||
| 			 | ||||
| 			if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDGnomeKeyring.Selection.GetSelected (out modelSecret, out iterSecret) ) | ||||
| @@ -605,9 +604,10 @@ public class GnomeKeyring : Store | ||||
| 					} | ||||
| 				} | ||||
| 				while( tsKeyValue.IterNext(ref iterKey) ); | ||||
| 			} | ||||
| 				AggregateStore(); | ||||
| 			}	 | ||||
| 			}						 | ||||
| 			 | ||||
| 		} | ||||
| 		catch(Exception exp) | ||||
| 		{ | ||||
|   | ||||
| @@ -338,7 +338,7 @@ public class KdeWallet : Store | ||||
| 			 | ||||
| 			if( false == entrySecretID.Editable ) | ||||
| 			{ | ||||
| 				if( ("" != args.NewText) && (KeyValue != args.NewText) ) | ||||
| 				if( ("" != args.NewText) && (Common.MAX_LEN >= args.NewText.Length) && (KeyValue != args.NewText) ) | ||||
| 				if(  Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_KDEWALLET, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) ) | ||||
| 				{ | ||||
| 					Logger.DbgLog("GUI:KdeWallet.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded"); | ||||
| @@ -358,7 +358,7 @@ public class KdeWallet : Store | ||||
| 							break; | ||||
| 						} | ||||
| 					} | ||||
| 					AggregateStore(); | ||||
| 					//AggregateStore(); | ||||
| 				} | ||||
| 				else | ||||
| 					Logger.DbgLog("GUI:KdeWallet.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); | ||||
| @@ -586,7 +586,7 @@ public class KdeWallet : Store | ||||
| 						Logger.DbgLog("GUI:KdeWallet.on_buttonManageOk_clicked() - DELETE_KEY_FAILED.");	 | ||||
| 				} | ||||
| 				arrDeletedKeys.Clear(); | ||||
| 				AggregateStore();			 | ||||
| 							 | ||||
| 			}			 | ||||
| 			 | ||||
| 			if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDKdeWallet.Selection.GetSelected (out modelSecret, out iterSecret) ) | ||||
| @@ -606,8 +606,9 @@ public class KdeWallet : Store | ||||
| 					} | ||||
| 				} | ||||
| 				while( tsKeyValue.IterNext(ref iterKey) );									 | ||||
| 				AggregateStore(); | ||||
| 				 | ||||
| 			} | ||||
| 				AggregateStore(); | ||||
| 			}						 | ||||
| 		} | ||||
| 		catch(Exception exp) | ||||
|   | ||||
| @@ -364,7 +364,7 @@ public class MiCasa : Store | ||||
| 			 | ||||
| 			if( false == entrySecretID.Editable ) | ||||
| 			{ | ||||
| 				if( ("" != args.NewText) && (KeyValue != args.NewText) ) | ||||
| 				if( ("" != args.NewText) && (Common.MAX_LEN >= args.NewText.Length) && (KeyValue != args.NewText) ) | ||||
| 				if(  Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_MICASA, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) ) | ||||
| 				{ | ||||
| 					Logger.DbgLog("GUI:MiCasa.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded"); | ||||
| @@ -384,7 +384,7 @@ public class MiCasa : Store | ||||
| 							break; | ||||
| 						} | ||||
| 					} | ||||
| 					AggregateStore(); | ||||
| 					//AggregateStore(); | ||||
| 				} | ||||
| 				else | ||||
| 					Logger.DbgLog("GUI:MiCasa.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); | ||||
| @@ -679,7 +679,7 @@ public class MiCasa : Store | ||||
| 						Logger.DbgLog("GUI:MiCasa.on_buttonManageOk_clicked() - DELETE_KEY_FAILED.");	 | ||||
| 				} | ||||
| 				arrDeletedKeys.Clear(); | ||||
| 				AggregateStore();			 | ||||
| 							 | ||||
| 			}			 | ||||
| 			 | ||||
| 			if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDMiCasa.Selection.GetSelected (out modelSecret, out iterSecret) ) | ||||
| @@ -699,8 +699,9 @@ public class MiCasa : Store | ||||
| 					} | ||||
| 				} | ||||
| 				while( tsKeyValue.IterNext(ref iterKey) );									 | ||||
| 				AggregateStore(); | ||||
| 				 | ||||
| 			} | ||||
| 				AggregateStore(); | ||||
| 			}						 | ||||
| 		} | ||||
| 		catch(Exception exp) | ||||
|   | ||||
		Reference in New Issue
	
	Block a user