geos_one/CASA
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-------------------------------------------------------------------

Browse Source 
Thu May  4 17:38:25 IST 2006 - smanojna@novell.com

- Description:
  1. Fixed Bug 170854: CASAGui only allows one edit at a time.
  2. Added 512 character limit during the edit operation, i.e.
     the newly edited value string cannot be longer than 512.
  3. Fixed a bug caused during deleting and adding new key-value pairs,
     this bug had not been filed in Bugzilla.
     -In the manage secret dialog, delete a key-value pair.
     -Add a new key with the same name as the one deleted above but
      but with a different value.
     -When you click the OK button the changes are not effected.

- Modified files:
  c_gui/MiCasa.cs
  c_gui/Firefox.cs
  c_gui/GnomeKeyring.cs
  c_gui/KdeWallet.cs
  c_gui/Common.cs

-------------------------------------------------------------------
This commit is contained in:
smanojna 2006-05-04 12:10:52 +00:00
parent 7d5b46c59e
commit 021e3b16e5
6 changed files with 42 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
CASA.changes
View File

@ -1,3 +1,24 @@
-------------------------------------------------------------------
Thu May 4 17:38:25 IST 2006 - smanojna@novell.com
- Description:
1. Fixed Bug 170854: CASAGui only allows one edit at a time.
2. Added 512 character limit during the edit operation, i.e.
the newly edited value string cannot be longer than 512.
3. Fixed a bug caused during deleting and adding new key-value pairs,
this bug had not been filed in Bugzilla.
-In the manage secret dialog, delete a key-value pair.
-Add a new key with the same name as the one deleted above but
but with a different value.
-When you click the OK button the changes are not effected.
- Modified files:
c_gui/MiCasa.cs
c_gui/Firefox.cs
c_gui/GnomeKeyring.cs
c_gui/KdeWallet.cs
c_gui/Common.cs
------------------------------------------------------------------- -------------------------------------------------------------------
Thu May 4 15:23:17 IST 2006 - smanojna@novell.com Thu May 4 15:23:17 IST 2006 - smanojna@novell.com

3
c_gui/Common.cs
View File

@ -59,7 +59,8 @@ public class Common
public static string GladeFile = null, public static string GladeFile = null,
DebugLogFile = null; DebugLogFile = null;
public static int MAX_LEN = 512;
///############################################################## ///##############################################################
/// SPI CONSTANTS /// SPI CONSTANTS
/// ///

2
c_gui/Firefox.cs
View File

@ -323,7 +323,7 @@ public class Firefox : Store
break; break;
} }
} }
AggregateStore(); //AggregateStore();
} }
else else
Logger.DbgLog("GUI:Firefox.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); Logger.DbgLog("GUI:Firefox.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED");

14
c_gui/GnomeKeyring.cs
View File

@ -338,7 +338,7 @@ public class GnomeKeyring : Store
if( false == entrySecretID.Editable ) if( false == entrySecretID.Editable )
{ {
if( ("" != args.NewText) && (KeyValue != args.NewText) ) if( ("" != args.NewText) && (Common.MAX_LEN >= args.NewText.Length) && (KeyValue != args.NewText) )
if( Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_GNOMEKEYRING, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) ) if( Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_GNOMEKEYRING, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) )
{ {
Logger.DbgLog("GUI:GnomeKeyring.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded"); Logger.DbgLog("GUI:GnomeKeyring.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded");
@ -358,7 +358,7 @@ public class GnomeKeyring : Store
break; break;
} }
} }
AggregateStore(); //AggregateStore();
} }
else else
Logger.DbgLog("GUI:GnomeKeyring.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); Logger.DbgLog("GUI:GnomeKeyring.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED");
@ -584,8 +584,7 @@ public class GnomeKeyring : Store
else else
Logger.DbgLog("GUI:GnomeKeyring.on_buttonManageOk_clicked() - DELETE_KEY_FAILED."); Logger.DbgLog("GUI:GnomeKeyring.on_buttonManageOk_clicked() - DELETE_KEY_FAILED.");
} }
arrDeletedKeys.Clear(); arrDeletedKeys.Clear();
AggregateStore();
} }
if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDGnomeKeyring.Selection.GetSelected (out modelSecret, out iterSecret) ) if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDGnomeKeyring.Selection.GetSelected (out modelSecret, out iterSecret) )
@ -604,10 +603,11 @@ public class GnomeKeyring : Store
Logger.DbgLog("GUI:GnomeKeyring.on_buttonManageOk_clicked() - ADD_KEY_VALUE_FAILED."); Logger.DbgLog("GUI:GnomeKeyring.on_buttonManageOk_clicked() - ADD_KEY_VALUE_FAILED.");
} }
} }
while( tsKeyValue.IterNext(ref iterKey) ); while( tsKeyValue.IterNext(ref iterKey) );
AggregateStore();
} }
} AggregateStore();
}
} }
catch(Exception exp) catch(Exception exp)
{ {

9
c_gui/KdeWallet.cs
View File

@ -338,7 +338,7 @@ public class KdeWallet : Store
if( false == entrySecretID.Editable ) if( false == entrySecretID.Editable )
{ {
if( ("" != args.NewText) && (KeyValue != args.NewText) ) if( ("" != args.NewText) && (Common.MAX_LEN >= args.NewText.Length) && (KeyValue != args.NewText) )
if( Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_KDEWALLET, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) ) if( Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_KDEWALLET, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) )
{ {
Logger.DbgLog("GUI:KdeWallet.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded"); Logger.DbgLog("GUI:KdeWallet.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded");
@ -358,7 +358,7 @@ public class KdeWallet : Store
break; break;
} }
} }
AggregateStore(); //AggregateStore();
} }
else else
Logger.DbgLog("GUI:KdeWallet.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); Logger.DbgLog("GUI:KdeWallet.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED");
@ -586,7 +586,7 @@ public class KdeWallet : Store
Logger.DbgLog("GUI:KdeWallet.on_buttonManageOk_clicked() - DELETE_KEY_FAILED."); Logger.DbgLog("GUI:KdeWallet.on_buttonManageOk_clicked() - DELETE_KEY_FAILED.");
} }
arrDeletedKeys.Clear(); arrDeletedKeys.Clear();
AggregateStore();
} }
if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDKdeWallet.Selection.GetSelected (out modelSecret, out iterSecret) ) if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDKdeWallet.Selection.GetSelected (out modelSecret, out iterSecret) )
@ -606,8 +606,9 @@ public class KdeWallet : Store
} }
} }
while( tsKeyValue.IterNext(ref iterKey) ); while( tsKeyValue.IterNext(ref iterKey) );
AggregateStore();
} }
AggregateStore();
} }
} }
catch(Exception exp) catch(Exception exp)

11
c_gui/MiCasa.cs
View File

@ -287,7 +287,7 @@ public class MiCasa : Store
cellEditable = new CellRendererText(); cellEditable = new CellRendererText();
cellEditable.Editable = true; cellEditable.Editable = true;
cellEditable.Edited += new EditedHandler(OnKeyValueEdited); cellEditable.Edited += new EditedHandler(OnKeyValueEdited);
/// KEY:0 VALUE:1 VALUE-DUP:2 DIRTY-BIT:3 LINK:4 /// KEY:0 VALUE:1 VALUE-DUP:2 DIRTY-BIT:3 LINK:4
tsKeyValue = new TreeStore(typeof(string),typeof(string), typeof(string), typeof(bool), typeof(string)); tsKeyValue = new TreeStore(typeof(string),typeof(string), typeof(string), typeof(bool), typeof(string));
tvKeyValue.AppendColumn("Key",new CellRendererText(),"text",0); tvKeyValue.AppendColumn("Key",new CellRendererText(),"text",0);
tvKeyValue.AppendColumn("Value",cellEditable,"text",2); tvKeyValue.AppendColumn("Value",cellEditable,"text",2);
@ -364,7 +364,7 @@ public class MiCasa : Store
if( false == entrySecretID.Editable ) if( false == entrySecretID.Editable )
{ {
if( ("" != args.NewText) && (KeyValue != args.NewText) ) if( ("" != args.NewText) && (Common.MAX_LEN >= args.NewText.Length) && (KeyValue != args.NewText) )
if( Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_MICASA, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) ) if( Common.STATUS_SUCCESS == StoreDataInterface.UpdateStore(Common.STORE_MICASA, Common.OPERATION_MODIFY_KEY, KeyName, args.NewText, ref model, ref iter) )
{ {
Logger.DbgLog("GUI:MiCasa.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded"); Logger.DbgLog("GUI:MiCasa.OnKeyValueEdited() - StoreDataInterface.UpdateStore() succeeded");
@ -384,7 +384,7 @@ public class MiCasa : Store
break; break;
} }
} }
AggregateStore(); //AggregateStore();
} }
else else
Logger.DbgLog("GUI:MiCasa.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED"); Logger.DbgLog("GUI:MiCasa.OnKeyValueEdited() - ERROR: STATUS_STORE_UPDATEFAILED");
@ -679,7 +679,7 @@ public class MiCasa : Store
Logger.DbgLog("GUI:MiCasa.on_buttonManageOk_clicked() - DELETE_KEY_FAILED."); Logger.DbgLog("GUI:MiCasa.on_buttonManageOk_clicked() - DELETE_KEY_FAILED.");
} }
arrDeletedKeys.Clear(); arrDeletedKeys.Clear();
AggregateStore();
} }
if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDMiCasa.Selection.GetSelected (out modelSecret, out iterSecret) ) if( tsKeyValue.GetIterFirst(out iterKey) && tvSecretIDMiCasa.Selection.GetSelected (out modelSecret, out iterSecret) )
@ -699,8 +699,9 @@ public class MiCasa : Store
} }
} }
while( tsKeyValue.IterNext(ref iterKey) ); while( tsKeyValue.IterNext(ref iterKey) );
AggregateStore();
} }
AggregateStore();
} }
} }
catch(Exception exp) catch(Exception exp)