New upstream version 8.1.0
This commit is contained in:
geos_one
294
meta/source/net/message/storage/creating/UnlinkFileMsgEx.cpp
Normal file
294
meta/source/net/message/storage/creating/UnlinkFileMsgEx.cpp
Normal file
@@ -0,0 +1,294 @@
|
||||
#include <common/net/message/storage/creating/UnlinkLocalFileInodeMsg.h>
|
||||
#include <common/net/message/storage/creating/UnlinkLocalFileInodeRespMsg.h>
|
||||
#include <components/FileEventLogger.h>
|
||||
#include <net/msghelpers/MsgHelperUnlink.h>
|
||||
#include <program/Program.h>
|
||||
#include "UnlinkFileMsgEx.h"
|
||||
|
||||
std::tuple<HashDirLock, FileIDLock, ParentNameLock, FileIDLock> UnlinkFileMsgEx::lock(EntryLockStore& store)
|
||||
{
|
||||
HashDirLock hashLock;
|
||||
FileIDLock inodeLock;
|
||||
|
||||
// we also have to lock the inode attached to the dentry - if we delete the inode, we must
|
||||
// exclude concurrent actions on the same inode. if we cannot look up a file inode for the
|
||||
// dentry, nothing bad happens.
|
||||
MetaStore* metaStore = Program::getApp()->getMetaStore();
|
||||
auto dir = metaStore->referenceDir(getParentInfo()->getEntryID(),
|
||||
getParentInfo()->getIsBuddyMirrored(), false);
|
||||
|
||||
DirEntry dentry(getDelFileName());
|
||||
bool dentryExists = dir->getFileDentry(getDelFileName(), dentry);
|
||||
|
||||
if (dentryExists)
|
||||
{
|
||||
dentry.getEntryInfo(getParentInfo()->getEntryID(), 0, &fileInfo);
|
||||
|
||||
// lock hash dir where we are going to remove (or update) file inode
|
||||
// need to take it only if it is a non-inlined inode and resynch is running
|
||||
if (resyncJob && resyncJob->isRunning() && !dentry.getIsInodeInlined())
|
||||
hashLock = {&store, MetaStorageTk::getMetaInodeHash(dentry.getID())};
|
||||
}
|
||||
|
||||
FileIDLock dirLock(&store, getParentInfo()->getEntryID(), true);
|
||||
ParentNameLock dentryLock(&store, getParentInfo()->getEntryID(), getDelFileName());
|
||||
|
||||
if (dentryExists)
|
||||
inodeLock = {&store, dentry.getID(), true};
|
||||
|
||||
metaStore->releaseDir(dir->getID());
|
||||
return std::make_tuple(std::move(hashLock), std::move(dirLock), std::move(dentryLock), std::move(inodeLock));
|
||||
}
|
||||
|
||||
bool UnlinkFileMsgEx::processIncoming(ResponseContext& ctx)
|
||||
{
|
||||
#ifdef BEEGFS_DEBUG
|
||||
const char* logContext = "UnlinkFileMsg incoming";
|
||||
|
||||
const std::string& removeName = getDelFileName();
|
||||
EntryInfo* parentInfo = getParentInfo();
|
||||
LOG_DEBUG(logContext, Log_DEBUG, "ParentID: " + parentInfo->getEntryID() + "; "
|
||||
"deleteName: " + removeName);
|
||||
#endif // BEEGFS_DEBUG
|
||||
|
||||
// update operation counters (here on top because we have an early sock release in this msg)
|
||||
updateNodeOp(ctx, MetaOpCounter_UNLINK);
|
||||
|
||||
return BaseType::processIncoming(ctx);
|
||||
}
|
||||
|
||||
std::unique_ptr<MirroredMessageResponseState> UnlinkFileMsgEx::executeLocally(
|
||||
ResponseContext& ctx, bool isSecondary)
|
||||
{
|
||||
const char* logContext = "Unlink File Msg";
|
||||
App* app = Program::getApp();
|
||||
MetaStore* metaStore = app->getMetaStore();
|
||||
|
||||
// reference parent dir
|
||||
DirInode* dir = metaStore->referenceDir(getParentInfo()->getEntryID(),
|
||||
getParentInfo()->getIsBuddyMirrored(), true);
|
||||
|
||||
if (!dir)
|
||||
return boost::make_unique<ResponseState>(FhgfsOpsErr_PATHNOTEXISTS);
|
||||
|
||||
DirEntry dentryToRemove(getDelFileName());
|
||||
if (!dir->getFileDentry(getDelFileName(), dentryToRemove))
|
||||
{
|
||||
metaStore->releaseDir(dir->getID());
|
||||
return boost::make_unique<ResponseState>(FhgfsOpsErr_PATHNOTEXISTS);
|
||||
}
|
||||
|
||||
// On meta-mirrored setup, ensure the dentry we just loaded i.e. 'dentryToRemove' has the same entryID as 'fileInfo'.
|
||||
// This check is crucial to detect a very rare race condition where dentry gets unlinked
|
||||
// because the parent directory was not locked during UnlinkFileMsgEx::lock(),
|
||||
// and then reappears because the same file is being created again. If the entryIDs
|
||||
// don't match, it means the dentry has changed, and the exclusive lock taken on the
|
||||
// entryID before won't be effective in preventing future races of ongoing unlink
|
||||
// operation with other filesystem operations (e.g. close()) which might happen on this file.
|
||||
// Therefore, we release the directory from the meta store and return an error saying path
|
||||
// not exists.
|
||||
if (isMirrored() && (dentryToRemove.getEntryID() != this->fileInfo.getEntryID()))
|
||||
{
|
||||
metaStore->releaseDir(dir->getID());
|
||||
return boost::make_unique<ResponseState>(FhgfsOpsErr_PATHNOTEXISTS);
|
||||
}
|
||||
|
||||
// re-fetch entryInfo
|
||||
dentryToRemove.getEntryInfo(getParentInfo()->getEntryID(), 0, &fileInfo);
|
||||
|
||||
// check whether local node/group owns file's inode (dentry's owner may/maynot be same)
|
||||
NumNodeID ownerNodeID = fileInfo.getOwnerNodeID();
|
||||
if ( (!isMirrored() && ownerNodeID == app->getLocalNode().getNumID()) ||
|
||||
(isMirrored() &&
|
||||
ownerNodeID.val() == app->getMetaBuddyGroupMapper()->getLocalGroupID()) )
|
||||
{
|
||||
// File inode is on the same metadata node/buddy group as the dentry.
|
||||
if (isSecondary)
|
||||
return executeSecondary(ctx, *dir);
|
||||
else
|
||||
return executePrimary(ctx, *dir);
|
||||
}
|
||||
else
|
||||
{ // Handle case where file inode is on a different metadata node/buddy group than dentry.
|
||||
// Step 1: Remove file's dentry (local operation)
|
||||
// Note: Dentry was already loaded and validated earlier
|
||||
FhgfsOpsErr unlinkRes = FhgfsOpsErr_INTERNAL;
|
||||
unlinkRes = dir->unlinkDirEntry(getDelFileName(), &dentryToRemove, DirEntry_UNLINK_FILENAME);
|
||||
metaStore->releaseDir(dir->getID());
|
||||
if (unlinkRes != FhgfsOpsErr_SUCCESS)
|
||||
return boost::make_unique<ResponseState>(unlinkRes);
|
||||
|
||||
// Step 2: Remove file's inode (remote operation)
|
||||
if (!isSecondary)
|
||||
{
|
||||
unsigned preUnlinkHardlinkCount = 0;
|
||||
|
||||
UnlinkLocalFileInodeMsg unlinkInodeMsg(&fileInfo);
|
||||
RequestResponseArgs rrArgs(NULL, &unlinkInodeMsg, NETMSGTYPE_UnlinkLocalFileInodeResp);
|
||||
RequestResponseNode rrNode(ownerNodeID, app->getMetaNodes());
|
||||
rrNode.setTargetStates(app->getMetaStateStore());
|
||||
if (fileInfo.getIsBuddyMirrored())
|
||||
{
|
||||
rrNode.setMirrorInfo(app->getMetaBuddyGroupMapper(), false);
|
||||
}
|
||||
|
||||
do
|
||||
{
|
||||
FhgfsOpsErr resp = MessagingTk::requestResponseNode(&rrNode, &rrArgs);
|
||||
if (unlikely(resp != FhgfsOpsErr_SUCCESS))
|
||||
{
|
||||
LogContext(logContext).log(Log_WARNING,
|
||||
"Communication with metadata server failed. "
|
||||
"nodeID: " + ownerNodeID.str() + "; " +
|
||||
"entryID: " + fileInfo.getEntryID().c_str());
|
||||
break;
|
||||
}
|
||||
|
||||
// response received
|
||||
const auto respMsg = (UnlinkLocalFileInodeRespMsg*) rrArgs.outRespMsg.get();
|
||||
FhgfsOpsErr res = respMsg->getResult();
|
||||
if (res != FhgfsOpsErr_SUCCESS)
|
||||
{
|
||||
// error: either inode file doesn't exists or some other error happened
|
||||
LogContext(logContext).log(Log_WARNING, "unlink file inode failed! "
|
||||
"nodeID: " + ownerNodeID.str() + "; " +
|
||||
"entryID: " + fileInfo.getEntryID().c_str());
|
||||
break;
|
||||
}
|
||||
|
||||
// since dentry has been removed successfully so all good for user - no need
|
||||
// to return an error if unlinking remote inode fails due to some reasons.
|
||||
// we still need to remove dentry from secondary buddy so should not overwrite
|
||||
// local dentry removal success with some remote error
|
||||
unlinkRes = FhgfsOpsErr_SUCCESS;
|
||||
preUnlinkHardlinkCount = respMsg->getPreUnlinkHardlinkCount();
|
||||
} while (false);
|
||||
|
||||
if (unlinkRes == FhgfsOpsErr_SUCCESS && app->getFileEventLogger() && getFileEvent())
|
||||
{
|
||||
// Determine remaining hardlinks after unlink operation
|
||||
unsigned remainingLinks = (preUnlinkHardlinkCount > 0) ? preUnlinkHardlinkCount - 1 : 0;
|
||||
|
||||
EventContext eventCtx = makeEventContext(&fileInfo, getParentInfo()->getEntryID(),
|
||||
getMsgHeaderUserID(), "", remainingLinks, isSecondary);
|
||||
logEvent(app->getFileEventLogger(), *getFileEvent(), eventCtx);
|
||||
}
|
||||
}
|
||||
|
||||
return boost::make_unique<ResponseState>(unlinkRes);
|
||||
}
|
||||
|
||||
// Should never reach this point but added to please the compiler
|
||||
return boost::make_unique<ResponseState>(FhgfsOpsErr_SUCCESS);
|
||||
}
|
||||
|
||||
std::unique_ptr<UnlinkFileMsgEx::ResponseState> UnlinkFileMsgEx::executePrimary(
|
||||
ResponseContext& ctx, DirInode& dir)
|
||||
{
|
||||
App* app = Program::getApp();
|
||||
unsigned preUnlinkHardlinkCount = 0; // number of hardlink(s) before unlink happens
|
||||
|
||||
// Two alternatives:
|
||||
// 1) early response before chunk files unlink.
|
||||
// 2) normal response after chunk files unlink (incl. chunk files error).
|
||||
if (app->getConfig()->getTuneEarlyUnlinkResponse() && !isMirrored())
|
||||
{
|
||||
// alternative 1: response before chunk files unlink
|
||||
std::unique_ptr<FileInode> unlinkedInode;
|
||||
|
||||
FhgfsOpsErr unlinkMetaRes = MsgHelperUnlink::unlinkMetaFile(dir,
|
||||
getDelFileName(), &unlinkedInode, preUnlinkHardlinkCount);
|
||||
|
||||
app->getMetaStore()->releaseDir(dir.getID());
|
||||
earlyComplete(ctx, ResponseState(unlinkMetaRes));
|
||||
|
||||
/* note: if the file is still opened or if there were hardlinks then unlinkedInode will be
|
||||
NULL even on FhgfsOpsErr_SUCCESS */
|
||||
if ((unlinkMetaRes == FhgfsOpsErr_SUCCESS) && unlinkedInode)
|
||||
MsgHelperUnlink::unlinkChunkFiles(unlinkedInode.release(), getMsgHeaderUserID() );
|
||||
|
||||
if (unlinkMetaRes == FhgfsOpsErr_SUCCESS && app->getFileEventLogger() && getFileEvent())
|
||||
{
|
||||
// Determine remaining hardlinks after unlink operation
|
||||
unsigned remainingLinks = (preUnlinkHardlinkCount > 0) ? preUnlinkHardlinkCount - 1 : 0;
|
||||
|
||||
EventContext eventCtx = makeEventContext(&fileInfo, getParentInfo()->getEntryID(),
|
||||
// This is not the secondary node if executePrimary() was called.
|
||||
getMsgHeaderUserID(), "", remainingLinks, false);
|
||||
logEvent(app->getFileEventLogger(), *getFileEvent(), eventCtx);
|
||||
}
|
||||
|
||||
return {};
|
||||
}
|
||||
|
||||
// alternative 2: response after chunk files unlink
|
||||
std::unique_ptr<FileInode> unlinkedInode;
|
||||
FhgfsOpsErr unlinkRes = MsgHelperUnlink::unlinkMetaFile(dir,
|
||||
getDelFileName(), &unlinkedInode, preUnlinkHardlinkCount);
|
||||
|
||||
if ((unlinkRes == FhgfsOpsErr_SUCCESS) && shouldFixTimestamps())
|
||||
{
|
||||
fixInodeTimestamp(dir, dirTimestamps);
|
||||
if (!unlinkedInode)
|
||||
{
|
||||
auto [file, referenceRes] = app->getMetaStore()->referenceFile(&fileInfo);
|
||||
if (file)
|
||||
{
|
||||
fixInodeTimestamp(*file, fileTimestamps, &fileInfo);
|
||||
app->getMetaStore()->releaseFile(dir.getID(), file);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/* note: if the file is still opened or if there are/were hardlinks then unlinkedInode will be
|
||||
NULL even on FhgfsOpsErr_SUCCESS */
|
||||
if ((unlinkRes == FhgfsOpsErr_SUCCESS) && unlinkedInode)
|
||||
MsgHelperUnlink::unlinkChunkFiles(unlinkedInode.release(), getMsgHeaderUserID());
|
||||
|
||||
app->getMetaStore()->releaseDir(dir.getID());
|
||||
if ((unlinkRes == FhgfsOpsErr_SUCCESS) && app->getFileEventLogger() && getFileEvent())
|
||||
{
|
||||
// Determine remaining hardlinks after unlink operation
|
||||
unsigned remainingLinks = (preUnlinkHardlinkCount > 0) ? preUnlinkHardlinkCount - 1 : 0;
|
||||
|
||||
EventContext eventCtx = makeEventContext(&fileInfo, getParentInfo()->getEntryID(),
|
||||
// This is not the secondary node if executePrimary() was called.
|
||||
getMsgHeaderUserID(), "", remainingLinks, false);
|
||||
logEvent(app->getFileEventLogger(), *getFileEvent(), eventCtx);
|
||||
}
|
||||
|
||||
return boost::make_unique<ResponseState>(unlinkRes);
|
||||
}
|
||||
|
||||
std::unique_ptr<UnlinkFileMsgEx::ResponseState> UnlinkFileMsgEx::executeSecondary(
|
||||
ResponseContext& ctx, DirInode& dir)
|
||||
{
|
||||
MetaStore* const metaStore = Program::getApp()->getMetaStore();
|
||||
std::unique_ptr<FileInode> unlinkedInode;
|
||||
unsigned preUnlinkHardlinkCount; // Not used here!
|
||||
|
||||
FhgfsOpsErr unlinkMetaRes = MsgHelperUnlink::unlinkMetaFile(dir,
|
||||
getDelFileName(), &unlinkedInode, preUnlinkHardlinkCount);
|
||||
|
||||
if ((unlinkMetaRes == FhgfsOpsErr_SUCCESS) && shouldFixTimestamps())
|
||||
{
|
||||
fixInodeTimestamp(dir, dirTimestamps);
|
||||
if (!unlinkedInode)
|
||||
{
|
||||
auto [file, referenceRes] = metaStore->referenceFile(&fileInfo);
|
||||
if (file)
|
||||
{
|
||||
fixInodeTimestamp(*file, fileTimestamps, &fileInfo);
|
||||
metaStore->releaseFile(dir.getID(), file);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
metaStore->releaseDir(dir.getID());
|
||||
return boost::make_unique<ResponseState>(unlinkMetaRes);
|
||||
}
|
||||
|
||||
void UnlinkFileMsgEx::forwardToSecondary(ResponseContext& ctx)
|
||||
{
|
||||
sendToSecondary(ctx, *this, NETMSGTYPE_UnlinkFileResp);
|
||||
}
|
||||
Reference in New Issue
Block a user